-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[member-ordering] support abstract methods #395
Copy link
Copy link
Closed
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershas prthere is a PR raised to close thisthere is a PR raised to close thispackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershas prthere is a PR raised to close thisthere is a PR raised to close thispackage: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-plugin
Repro
{ "rules": { "@typescript-eslint/member-ordering": [ "error", { "default": [ "public-instance-method", "private-instance-method" ] } ], } }Expected Result
No error
Actual Result
Additional Info
Abstract methods are not necessarily private methods. There are two issues here:
This came up when I tried to migrate my TSLint config containing:
and I failed due to errors around abstract methods handling.
Versions
@typescript-eslint/eslint-plugin1.5.0@typescript-eslint/parser1.5.0TypeScript3.3.4000ESLint5.15.3nodev8.15.1npmyarn1.15.2