Skip to content

Enhancement: align TSImportType with ImportExpression #11583

@fisker

Description

@fisker

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

ast-spec

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

For similar code

let value = import("foo")
type type = import("foo")

The first was ImportExpression with source(Literal) property, while the second was TSImportType with argument(TSLiteralType).

Do you think they can share the same structure by changing TSImportType.argument to TSImportType.source and removing the TSLiteralType wrapper?

Additional Info

Playground

Metadata

Metadata

Assignees

No one assigned

    Labels

    ASTPRs and Issues about the AST structureaccepting prsGo ahead, send a pull request that resolves this issuebreaking changeThis change will require a new major version to be releasedenhancementNew feature or requestpackage: ast-specIssues related to @typescript-eslint/ast-specpackage: typescript-estreeIssues related to @typescript-eslint/typescript-estree

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions