-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs
Description
Suggestion
This is explained already in #10582 but the summary is as follows:
We currently enable coverage in our test scripts and pass coverage=false when we want to disable it
This results in jest --coverage --coverage=false once everything is expanded
The duplicate flag works in jest but doesn't seem right. More importantly, it does not work with vitest (which we may soon want to move to).
We can solve this by having two scripts in each package:
testwith coverage disabledtest-coveragewith coverage enabled (if the package supports coverage)
CI can then call test-coverage instead of manually passing flag overrides
Additional Info
No response
Metadata
Metadata
Assignees
Labels
accepting prsGo ahead, send a pull request that resolves this issueGo ahead, send a pull request that resolves this issuerepo maintenancethings to do with maintenance of the repo, and not with code/docsthings to do with maintenance of the repo, and not with code/docs