Fix RWC missing file detection (microsoft#46673)

weswigham · web-flow · commit 4a065f524c1f · 2021-11-09T10:41:18.000-08:00
diff --git a/src/harness/harnessIO.ts b/src/harness/harnessIO.ts
@@ -1438,14 +1438,15 @@ namespace Harness {
             }
 
             const referenceDir = referencePath(relativeFileBase, opts && opts.Baselinefolder, opts && opts.Subfolder);
-            let existing = IO.readDirectory(referenceDir, referencedExtensions || [extension]);
+            let existing = IO.readDirectory(referenceDir, referencedExtensions || [extension]); // always an _absolute_ path
             if (extension === ".ts" || referencedExtensions && referencedExtensions.indexOf(".ts") > -1 && referencedExtensions.indexOf(".d.ts") === -1) {
                 // special-case and filter .d.ts out of .ts results
                 existing = existing.filter(f => !ts.endsWith(f, ".d.ts"));
             }
             const missing: string[] = [];
+            const absoluteTestDir = `${process.cwd()}/${referenceDir}`;
             for (const name of existing) {
-                const localCopy = name.substring(referenceDir.length - relativeFileBase.length);
+                const localCopy = name.substring(absoluteTestDir.length - relativeFileBase.length);
                 if (!writtenFiles.has(localCopy)) {
                     missing.push(localCopy);
                 }

Original file line number	Diff line number	Diff line change
`@@ -1438,14 +1438,15 @@ namespace Harness {`
`1438`	`1438`	`}`
`1439`	`1439`
`1440`	`1440`	`const referenceDir = referencePath(relativeFileBase, opts && opts.Baselinefolder, opts && opts.Subfolder);`
`1441`		`- let existing = IO.readDirectory(referenceDir, referencedExtensions \|\| [extension]);`
	`1441`	`+ let existing = IO.readDirectory(referenceDir, referencedExtensions \|\| [extension]); // always an _absolute_ path`
`1442`	`1442`	`if (extension === ".ts" \|\| referencedExtensions && referencedExtensions.indexOf(".ts") > -1 && referencedExtensions.indexOf(".d.ts") === -1) {`
`1443`	`1443`	`// special-case and filter .d.ts out of .ts results`
`1444`	`1444`	`existing = existing.filter(f => !ts.endsWith(f, ".d.ts"));`
`1445`	`1445`	`}`
`1446`	`1446`	`const missing: string[] = [];`
	`1447`	+ const absoluteTestDir = `${process.cwd()}/${referenceDir}`;
`1447`	`1448`	`for (const name of existing) {`
`1448`		`- const localCopy = name.substring(referenceDir.length - relativeFileBase.length);`
	`1449`	`+ const localCopy = name.substring(absoluteTestDir.length - relativeFileBase.length);`
`1449`	`1450`	`if (!writtenFiles.has(localCopy)) {`
`1450`	`1451`	`missing.push(localCopy);`
`1451`	`1452`	`}`