Skip to content

fix: aggregate function throw error when column alias name is set #9928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shenX-2021 wants to merge 1 commit into from
Closed

fix: aggregate function throw error when column alias name is set #9928

shenX-2021 wants to merge 1 commit into from

Conversation

@shenX-2021
Copy link
Contributor

@shenX-2021 shenX-2021 commented Apr 8, 2023 •
edited
Loading

Closes: #9927

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

pleerock
pleerock reviewed Apr 9, 2023
View reviewed changes
@pleerock
Copy link
Member

pleerock commented Apr 9, 2023

Can you please add the test confirming new behavior?

@shenX-2021 shenX-2021 requested a review from pleerock April 12, 2023 01:25
@shenX-2021
Copy link
Contributor Author

shenX-2021 commented May 5, 2023

@pleerock Can you merge this PR?

@pleerock
Copy link
Member

pleerock commented May 9, 2023

@shenX-2021 You have lint failing.

@shenX-2021 shenX-2021 closed this by deleting the head repository May 10, 2023
@pleerock
Copy link
Member

pleerock commented May 10, 2023

Not sure why you decided to close it, but in such case close the issue as well.

@shenX-2021
Copy link
Contributor Author

shenX-2021 commented May 10, 2023

it is something wrong with github, I try opening a new PR

@shenX-2021 shenX-2021 mentioned this pull request May 10, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pleerock pleerock Awaiting requested review from pleerock

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aggregate function throw error when column alias name is set

2 participants

@shenX-2021 @pleerock