Skip to content

fix: resolve issues for mssql migration when simple-enum was changed Fixes: #7785 #9457 #9771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexMesser merged 4 commits into from
Apr 5, 2023
Merged

fix: resolve issues for mssql migration when simple-enum was changed Fixes: #7785 #9457 #9771

AlexMesser merged 4 commits into from
Apr 5, 2023

Conversation

@ertl
Copy link
Contributor

@ertl ertl commented Feb 10, 2023 •
edited by AlexMesser
Loading

Description of change

fix: resolve issues for mssql migration when simple-enum was changed

  • Changes are now detected
  • Incorrect update Statement was split into a DROP CONSTRAINT and ADD CONSTRAINT Statement

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [~] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

ertl added 3 commits February 10, 2023 08:19
@ertl
fix: resolve issues for mssql migration when simple-enum was changed
024da43 
- Changes are now detected
- Incorrect update Statement was split into a DROP CONSTRAINT and ADD CONSTRAINT Statement

Closes: typeorm#7785 typeorm#9457
@ertl
fix: resolve issues for mssql migration when simple-enum was changed
a82fe22 
- Changes are now detected
- Incorrect update Statement was split into a DROP CONSTRAINT and ADD CONSTRAINT Statement

Closes: typeorm#7785 typeorm#9457
@ertl
Merge branch 'fix_#9457' of http://github.com/ertl/typeorm into fix_#…
c3bfcbc 
…9457
@ertl ertl changed the title Fix #9457 fix: resolve issues for mssql migration when simple-enum was changed Fixes: #7785 #9457 Feb 10, 2023
@AlexMesser
code refactoring;
748245b 
changed `enumName` usage to generated name;
improvements in test;
@AlexMesser AlexMesser merged commit cb154d4 into typeorm:master Apr 5, 2023
@AlexMesser
Copy link
Collaborator

AlexMesser commented Apr 5, 2023

thank you for contribution!

@ertl ertl deleted the fix_#9457 branch April 12, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@ertl @AlexMesser