Skip to content

Comments

build: local development with oracle#7881

Merged
pleerock merged 1 commit intotypeorm:masterfrom
satanTime:fix-5684-oracle
Nov 9, 2021
Merged

build: local development with oracle#7881
pleerock merged 1 commit intotypeorm:masterfrom
satanTime:fix-5684-oracle

Conversation

@satanTime
Copy link
Contributor

@satanTime satanTime commented Jul 10, 2021

Description of change

An easy way to run unit tests for Oracle XE locally

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@satanTime
Copy link
Contributor Author

satanTime commented Jul 10, 2021

Hi @imnotjames,

I hope this finds you well.

this is an independent PR regarding local testing with Oracle XE which was original implemented in #5685.

Looking forward for your review.
Thank you in advance!

@pleerock pleerock merged commit 4aaafdf into typeorm:master Nov 9, 2021
@pleerock
Copy link
Member

pleerock commented Nov 9, 2021

Looks good to me. Thank you for contribution!

HeartPattern pushed a commit to HeartPattern/typeorm that referenced this pull request Nov 29, 2021
@satanTime @HeartPattern
build: local development with oracle (typeorm#7881)
950ee93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@satanTime @pleerock