Skip to content

fix: prevent transactions in the Cordova driver #7771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imnotjames merged 1 commit into from
Jun 28, 2021
Merged

fix: prevent transactions in the Cordova driver #7771

imnotjames merged 1 commit into from
Jun 28, 2021

Conversation

@imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jun 20, 2021 •
edited
Loading

Description of change

the cordova driver silently ignores all attempts to begin
or commit transactions. this leads to data loss and invalid
operations occurring when developers expect transactions to work
and then they are silently ignored

fixes #4075

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/4075/block-cordova-transactions branch from 5d03a42 to 4980888 Compare June 20, 2021 23:12
@imnotjames
fix: prevent transactions in the Cordova driver
2dadd9d 
the cordova driver silently ignores all attempts to begin
or commit transactions.  this leads to data loss and invalid
operations occurring when developers expect transactions to work
and then they are silently ignored
@imnotjames imnotjames force-pushed the fix/4075/block-cordova-transactions branch from 4980888 to 2dadd9d Compare June 21, 2021 00:19
@imnotjames imnotjames marked this pull request as ready for review June 21, 2021 03:48
@imnotjames imnotjames mentioned this pull request Jun 21, 2021
Closed
@imnotjames imnotjames merged commit fc4133c into typeorm:master Jun 28, 2021
@imnotjames imnotjames deleted the fix/4075/block-cordova-transactions branch June 28, 2021 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

driver: cordova

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cordova driver using unsupported sql transaction statements

1 participant

@imnotjames