fix: datetime functions in column "default" leads to unnecessary queries during synchronization#7517
Merged
AlexMesser merged 13 commits intomasterfrom Apr 1, 2021
Merged
Conversation
default leads to unnecessary queries during synchronization
default leads to unnecessary queries during synchronization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Some databases transforms date functions to their aliases when the function used in column default, e.g.
CURRENT_TIMESTAMPstored asnow()in PostgreSQL. This PR adds mapping for these functions to fix synchronization problems.CURRENT_TIMESTAMP->now()CURRENT_TIMESTAMP(precision)->('now'::text)::timestamp(precision) with time zoneCURRENT_DATE->('now'::text)::dateCURRENT_TIME->('now'::text)::time with time zoneCURRENT_TIME(precision)->('now'::text)::time(precision) with time zoneLOCALTIME->('now'::text)::time without time zoneLOCALTIME(precision)->('now'::text)::time(precision) without time zoneLOCALTIMESTAMP->('now'::text)::timestamp without time zoneLOCALTIMESTAMP(precision)->('now'::text)::timestamp(precision) without time zoneCURRENT_TIMESTAMP->getdate()CURRENT_TIMESTAMP->current_timestamp()CURRENT_DATE->current_date()CURRENT_TIMESTAMP()->CURRENT_TIMESTAMPCURRENT_TIMESTAMP->CURRENT_TIMESTAMP()fixed issues:
Fixes #2136
Fixes #2718
Fixes #2737
Fixes #3561
Fixes #3991
Fixes #6412
Fixes #6579
Fixes #7381
covered pull-requests:
Closes #7229
Pull-Request Checklist
masterbranchnpm run testpasses with this changenpm run lintpasses with this changeFixes #0000N/ADocumentation has been updated to reflect this change