Skip to content

fix: Handle undefined querysets in QueryCommand#6910

Merged
pleerock merged 1 commit intotypeorm:masterfrom
imnotjames:fix/highlight-failed-query
Oct 16, 2020
Merged

fix: Handle undefined querysets in QueryCommand#6910
pleerock merged 1 commit intotypeorm:masterfrom
imnotjames:fix/highlight-failed-query

Conversation

@imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 15, 2020

When a query fails and returns undefined instead of an actual query set the QueryCommand has a TypeError.

fixes #6612

@imnotjames imnotjames force-pushed the fix/highlight-failed-query branch from f041d2d to 2d67b98 Compare October 15, 2020 17:14
@pleerock pleerock merged commit 6f285dc into typeorm:master Oct 16, 2020
@pleerock
Copy link
Member

Thank you!

@imnotjames imnotjames deleted the fix/highlight-failed-query branch October 16, 2020 05:47
@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 16, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted label hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"TypeError: Cannot read property 'replace' of undefined" on running the cli query command with several SQL statements

2 participants