perf: Use Optimized Queries for MySQLQueryRunner.loadTables#6886
Merged
imnotjames merged 1 commit intotypeorm:masterfrom Oct 15, 2020
Merged
perf: Use Optimized Queries for MySQLQueryRunner.loadTables#6886imnotjames merged 1 commit intotypeorm:masterfrom
imnotjames merged 1 commit intotypeorm:masterfrom
Conversation
49f3bf5 to
5ac0f45
Compare
Contributor
Author
|
Queries executed are as follows: @ronits-cx What do you think? |
Contributor
|
@imnotjames 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how we make queries against the MySQL
INFORMATION_SCHEMAmetadata tables to follow the performance guidelines in the MySQL documentation. This means that the queries are a LITTLE weird, but I included pretty verbose comments on the implementation.I did an
EXPLAINof every query that this generates & runs - each one requires the minimum amount of data to operate on & doesn't scan the database directories.This is verified via the tests in other locations that it's working still - Not sure the best technique to verify this.
closes #6820
fixes #6800