Mysql foreign key multi tenant fix#6828
Merged
imnotjames merged 31 commits intotypeorm:masterfrom Oct 4, 2020
Merged
Conversation
Add where clause to improve performance
added github packages
Fix indices query while maintaining performance
imnotjames
reviewed
Oct 4, 2020
imnotjames
reviewed
Oct 4, 2020
imnotjames
reviewed
Oct 4, 2020
imnotjames
requested changes
Oct 4, 2020
Contributor
imnotjames
left a comment
imnotjames
left a comment
There was a problem hiding this comment.
Left a few comments :)
imnotjames
approved these changes
Oct 4, 2020
Contributor
imnotjames
left a comment
imnotjames
left a comment
There was a problem hiding this comment.
🍏
Just waiting on tests to pass!
Contributor
Author
|
Awesome thanks! 😄 |
Contributor
|
Wonderful. Thank you for the contribution! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
Fixes an edge case where the wrong foreign key would be loaded when multiple databases exist with foreign keys that have the same name. Fixes typeorm#6168
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will fix issue 6168, where the foreign key queried might be wrong.
There is already another open PR for this issue: PR 6169.
The difference is that this PR is a split from another pending performance fix, which needs the condition to be where it is here in order to later add the performance fix.
The foreign key query has a JOIN and a where clause on the schema and table names, but the where clause is only for one of the tables in the join. This way in a multi-tenanted environment, it's possible for several schemas to have the same foreign key name, resulting in duplicate results in the query.