fix: use require in ReactNativeDriver#6814
Merged
pleerock merged 1 commit intotypeorm:masterfrom Oct 1, 2020
Merged
Conversation
Because react native uses the browser context we can't use `PlatformTools.load` so this reverts the behavior for this file to use a standard `require` call Fixes typeorm#6811
imnotjames
force-pushed
the
fix-react-native
branch
from
845bb87 to
af7e9b5
Compare
oleksandr-dziuban
approved these changes
Oct 1, 2020
oleksandr-dziuban
left a comment
oleksandr-dziuban
left a comment
There was a problem hiding this comment.
It's working perfectly now, double checked. Thanks a lot!
Member
|
Thank you @imnotjames ! |
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
Because react native uses the browser context we can't use `PlatformTools.load` so this reverts the behavior for this file to use a standard `require` call Fixes typeorm#6811
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because react native uses the browser context we can't use
PlatformTools.loadso this reverts the behavior for this file to use a standardrequirecallFixes #6811