Add absolute path support to other CLI commands#6807
Merged
imnotjames merged 1 commit intotypeorm:masterfrom Oct 1, 2020
Merged
Add absolute path support to other CLI commands#6807imnotjames merged 1 commit intotypeorm:masterfrom
imnotjames merged 1 commit intotypeorm:masterfrom
Conversation
imnotjames
approved these changes
Oct 1, 2020
Contributor
imnotjames
left a comment
imnotjames
left a comment
There was a problem hiding this comment.
Until we can confirm that adding path.resolve won't break anything I think this looks good to me.
Closed
Contributor
|
Oh no! This broke the build. |
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 1, 2020
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 1, 2020
…reateCommand somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues that cropped up after it was merged in
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 1, 2020
…reateCommand somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues that cropped up after it was merged in
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
…reateCommand (typeorm#6824) somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues that cropped up after it was merged in
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #6660 and adding absolute path support to the other CLI commands (sorry it took me so long!)
This is the same change + the type change necessary to prevent a breakage (someone please correct me if I'm missing anything)!
Thanks!