Skip to content

test: Fix typo in github issue 6442 test name#6554

Merged
imnotjames merged 2 commits intotypeorm:masterfrom
danmana:fix-test-typo
Oct 1, 2020
Merged

test: Fix typo in github issue 6442 test name#6554
imnotjames merged 2 commits intotypeorm:masterfrom
danmana:fix-test-typo

Conversation

@danmana
Copy link
Contributor

@danmana danmana commented Aug 12, 2020

No description provided.

@pleerock
Copy link
Member

pleerock commented Aug 16, 2020

@imnotjames do you have any ideas why this small change could fail a CI?

@imnotjames
Copy link
Contributor

imnotjames commented Aug 16, 2020

npm/cli#558

In particular

npm/cli#558 (comment)

npm v7 won't have this problem. (I'm working in the code that'll do this now.) I haven't checked into how involved it'd be to fix this issue for npm v6, but there's a good chance it'll just end up being "upgrade to v7 for the fix". In the meantime, I'd recommend using npm install instead of npm ci if this is affecting you.

This is likely because we upgraded fsevents or updated the lockfile on a machine which needed it.

We also probably want to use lock-verify to ensure the lockfile is in sync with the package list.

I'll take a look at a PR later today to try to resolve it. #6571

@imnotjames
Copy link
Contributor

Awesome. Looks like we're all good to go!

@imnotjames
Copy link
Contributor

Oh - one little thing for the future - this would be a test change rather than a chore change

https://github.com/typeorm/typeorm/blob/master/CONTRIBUTING.md#commit

It's a bit confusing to find the right one sometimes. I'll update the title for ya!

@imnotjames imnotjames changed the title chore: Fix typo in github issue test name test: Fix typo in github issue test name Oct 1, 2020
@imnotjames imnotjames changed the title test: Fix typo in github issue test name test: Fix typo in github issue 6442 test name Oct 1, 2020
@imnotjames imnotjames merged commit f3de0f6 into typeorm:master Oct 1, 2020
@imnotjames
Copy link
Contributor

Thanks for the contribution 🎉

@danmana danmana deleted the fix-test-typo branch October 2, 2020 12:59
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants