fix: support combination of many-to-one/cacade/explicit composite PK #6417
Merged
imnotjames merged 1 commit intotypeorm:masterfrom Oct 21, 2020
Merged
fix: support combination of many-to-one/cacade/explicit composite PK #6417imnotjames merged 1 commit intotypeorm:masterfrom
imnotjames merged 1 commit intotypeorm:masterfrom
Conversation
efbf143 to
880f58e
Compare
Contributor
Author
|
PS, through doing this I've found that there's a number of ways the surrounding code could be refactored to make something like this easier to update -
|
handle setting values deeply in entities with relations in ColumnMetadata, also check for a virtual relationship column in rawsqlresultstoentitytransformer this allows us to handle a case where `many-to-one` with explicit composite PKs columns were failing to persist a second time- instead of correctly updating the field they would cause an insert to occur leading to a unique PK constraint error
880f58e to
279340e
Compare
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
) handle setting values deeply in entities with relations in ColumnMetadata, also check for a virtual relationship column in rawsqlresultstoentitytransformer this allows us to handle a case where `many-to-one` with explicit composite PKs columns were failing to persist a second time- instead of correctly updating the field they would cause an insert to occur leading to a unique PK constraint error
jankarres
pushed a commit
to jankarres/typeorm
that referenced
this pull request
Oct 12, 2021
18 tasks
|
I just raised an issue which I think is linked to this: #10450 In my case the composite primary key being updated includes the foreign key to the parent and you get a constraint error. When updating a child with a single primary key or a composite key that does not include the foreign key, updating works ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle setting values deeply in entities with relations in ColumnMetadata,
also check for a virtual relationship column in rawsqlresultstoentitytransformer
this allows us to handle a case where
many-to-onewith explicit composite PKscolumns were failing to persist a second time- instead of correctly updating the
field they would cause an insert to occur leading to a unique PK constraint error
Fixes #6416
Fixes #4969
Fixes #4122