fix: synchronize column comment in mysql driver#6336
Closed
lusess123 wants to merge 2 commits intotypeorm:masterfrom
Closed
fix: synchronize column comment in mysql driver#6336lusess123 wants to merge 2 commits intotypeorm:masterfrom
lusess123 wants to merge 2 commits intotypeorm:masterfrom
Conversation
Member
|
I don't know why old code was comment, I guess for some particular reason. Since changes in schema sync can lead to problems I would avoid merging this PR for now, until @AlexMesser or somebody else can properly check it. |
Contributor
|
Looks like it was commented out for all drivers at some point because it wasn't available when the code was being originally written. @lusess123 if you could write a test to validate that this is working as expected that'd be stellar to get this merged in! |
merge master
This was referenced Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
column comment change synchronize to database