Closed
Conversation
Contributor
|
Unfortunately, we did pull in a different PR that accomplished this 🤔 but looking at this, I like that you used the I'll be closing this but I will probably make the change you made here the actual change we keep in the repo. |
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 5, 2020
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 5, 2020
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
imnotjames
added a commit
to imnotjames/typeorm
that referenced
this pull request
Oct 5, 2020
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
zaro
pushed a commit
to zaro/typeorm
that referenced
this pull request
Jan 12, 2021
in typeorm#6268 we pulled in a change that fixed the wrong FK getting loaded in a multi-database / multi-schema environment but in typeorm#6169 the approach was more desirable as it creates a simpler query that should be easier to change in the future as such, this pulls over that change from typeorm#6169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new clause for the join with
INFORMATION_SCHEMA.REFERENTIAL_CONSTRAINTSto prevent errors when there is more than one database in the server with foreign keys with same name.Closes #6168