Skip to content

Comments

fix: eager relation skips children relations#5685

Merged
imnotjames merged 1 commit intotypeorm:masterfrom
satanTime:fix-5684
Jul 11, 2021
Merged

fix: eager relation skips children relations#5685
imnotjames merged 1 commit intotypeorm:masterfrom
satanTime:fix-5684

Conversation

@satanTime
Copy link
Contributor

@satanTime satanTime commented Mar 14, 2020 •
edited
Loading

Closes #5169
Closes #5684

@satanTime satanTime changed the title fix: eager relation skips children relations #5684 fix: eager relation skips children relations Mar 15, 2020
@satanTime
Copy link
Contributor Author

satanTime commented Mar 27, 2020

Hi @pleerock,

the PR has been updated.

@satanTime
Copy link
Contributor Author

satanTime commented Apr 10, 2020

Hi @pleerock, could you review the PR?

@satanTime
Copy link
Contributor Author

satanTime commented Apr 17, 2020

Hi @pleerock, could you take a look?

@satanTime
Copy link
Contributor Author

satanTime commented Apr 24, 2020

Hi @pleerock, please let me know when you could review it.

@satanTime
Copy link
Contributor Author

satanTime commented May 1, 2020

Hey @pleerock, ping.

@satanTime satanTime mentioned this pull request Jan 26, 2021
Closed
@satanTime
Copy link
Contributor Author

satanTime commented Mar 6, 2021

Hi @pleerock,

could you take a look at this PR when you have time? I think, the related issue is important.

@R3D13 R3D13 mentioned this pull request Apr 13, 2021
Closed
@satanTime
Copy link
Contributor Author

satanTime commented Jun 30, 2021 •
edited
Loading

Hi @pleerock, @imnotjames,

I hope this finds you well.
Might you take a look at the PR? It is waiting for a review more than a year.

Thank you in advance.

imnotjames
imnotjames requested changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the Oracle and docker changes.

@satanTime satanTime mentioned this pull request Jul 10, 2021
Merged
7 tasks
@satanTime
Copy link
Contributor Author

satanTime commented Jul 10, 2021

Hi @imnotjames,

the PR has been updated to contain only the related changes.

imnotjames
imnotjames reviewed Jul 10, 2021
View reviewed changes
imnotjames
imnotjames approved these changes Jul 10, 2021
View reviewed changes
Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could refactor the leftJoin and addSelect to make this less of an issue but for now this makes sense.

@imnotjames imnotjames merged commit e7e887a into typeorm:master Jul 11, 2021
@imnotjames
Copy link
Contributor

imnotjames commented Jul 11, 2021

Thanks for your contribution!

@satanTime
Copy link
Contributor Author

satanTime commented Jul 11, 2021

Hi @imnotjames, thank you too!

It is nice to see, that there is a movement in the lib development after such a long time.
It is a cool lib, but, unfortunately, its maintenance was horrible.

@imnotjames
Copy link
Contributor

imnotjames commented Jul 11, 2021

Hi @imnotjames, thank you too!

It is nice to see, that there is a movement in the lib development after such a long time.
It is a cool lib, but, unfortunately, its maintenance was horrible.

Maintenance of such a large project is an incredibly demanding and difficult task - so I definitely wouldn't call any other work on this horrible. There's just times where your priorities may not align with the maintainers. 😄 Like keeping food on the table.

@chriswep chriswep mentioned this pull request Feb 17, 2022
Closed
@CHOIJEWON CHOIJEWON mentioned this pull request Feb 9, 2026
Closed
@wingding12 wingding12 mentioned this pull request Feb 10, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imnotjames imnotjames imnotjames approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

An eager relationship skips children relationships nested relations ignored if parent is eager

2 participants

@satanTime @imnotjames