Add option to Column to specify the complete enumName#4824
Merged
pleerock merged 1 commit intotypeorm:masterfrom Oct 18, 2019
ejose19:master
Merged
Add option to Column to specify the complete enumName#4824pleerock merged 1 commit intotypeorm:masterfrom ejose19:master
pleerock merged 1 commit intotypeorm:masterfrom
ejose19:master
Conversation
Contributor
Author
elmpp
reviewed
Oct 16, 2019
Contributor
elmpp
left a comment
elmpp
left a comment
There was a problem hiding this comment.
Looks extremely good to moi
Member
|
Okay, looks like many likes for this feature |
Contributor
Contributor
|
@ejose19 - am i'm right in thinking this won't affect the migrations generated? It appears they're still being prefixed with table names and ignoring the new I can take a crack at a PR if i can get a few pointers.. |
Contributor
Author
Member
|
Solution is to research how current approach works and refactor it considering these changes. |
jorenvandeweyer
added a commit
to jorenvandeweyer/typeorm
that referenced
this pull request
Apr 15, 2021
Added minor documentation for typeorm#4824
7 tasks
AlexMesser
pushed a commit
that referenced
this pull request
Apr 17, 2021
Added minor documentation for #4824
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #4106 and #4741