style(eslint): enable prefer-string-starts-ends-with rule - #12332

Description

@typescript-eslint/prefer-string-starts-ends-with is enabled as an error, but the codebase contains
existing string prefix checks using indexOf(...) === 0 (e.g., udtName.indexOf("_") === 0) that this
rule will flag, causing lint failures.

Code

eslint.config.mjs[41]

+            "@typescript-eslint/prefer-string-starts-ends-with": "error",

Evidence

The ESLint config enables prefer-string-starts-ends-with for all TypeScript files. Multiple TS
source files currently use string prefix checks via indexOf(...) === 0, which the rule flags and
requires converting to startsWith(...).

eslint.config.mjs[19-46]
src/driver/cockroachdb/CockroachQueryRunner.ts[3443-3446]
src/driver/cockroachdb/CockroachQueryRunner.ts[4457-4460]
src/driver/postgres/PostgresQueryRunner.ts[5108-5111]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`@typescript-eslint/prefer-string-starts-ends-with` is enabled as `error`, but there are existing prefix checks implemented as `str.indexOf("_") === 0`, which will fail lint.
## Issue Context
These checks should be rewritten to `str.startsWith("_")` (or otherwise refactored) to comply with the rule.
## Fix Focus Areas
- src/driver/cockroachdb/CockroachQueryRunner.ts[3443-3446]
- src/driver/cockroachdb/CockroachQueryRunner.ts[4457-4460]
- src/driver/postgres/PostgresQueryRunner.ts[5108-5111]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

@typescript-eslint/prefer-nullish-coalescing is enabled as an error, but the codebase contains
existing fallbacks using || on optional values (e.g., options: options || {}), which the rule
will flag and cause lint failures.

Code

eslint.config.mjs[40]

+            "@typescript-eslint/prefer-nullish-coalescing": "error",

Evidence

The ESLint config enables prefer-nullish-coalescing for all TypeScript files. At least one TS file
uses || to provide a default for an optional parameter (options?: ColumnOptions), which this
rule flags and expects to be rewritten using ??.

eslint.config.mjs[19-46]
src/decorator/columns/CreateDateColumn.ts[12-19]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`@typescript-eslint/prefer-nullish-coalescing` is enabled as `error`, but there are existing patterns like `options || {}` where `options` is optional, which will fail lint.
## Issue Context
Update nullish-defaulting sites to use `??` instead of `||` when the intent is to default only on `null`/`undefined`.
## Fix Focus Areas
- src/decorator/columns/CreateDateColumn.ts[12-19]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

The PR title/description claims @typescript-eslint/prefer-nullish-coalescing is being enabled, but
the ESLint config does not add that rule anywhere. This means the intended regression-prevention for
?? is not actually enforced.

Code

eslint.config.mjs[R37-43]

         // custom rules
         "@typescript-eslint/consistent-type-exports": "error",
         "@typescript-eslint/consistent-type-imports": "error",
+            "@typescript-eslint/prefer-string-starts-ends-with": "error",
         // exceptions from typescript-eslint/recommended
         "@typescript-eslint/ban-ts-comment": "warn",

Evidence

In the main TypeScript ruleset, only @typescript-eslint/prefer-string-starts-ends-with is added;
there is no @typescript-eslint/prefer-nullish-coalescing entry present in the rules block.

eslint.config.mjs[35-61]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
PR metadata says `@typescript-eslint/prefer-nullish-coalescing` is enabled, but the config doesn't include it.
## Issue Context
This creates a mismatch between the PR intent and actual enforcement.
## Fix Focus Areas
- eslint.config.mjs[35-61]
## Suggested change
Add the rule to the `rules` block, e.g.:

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Description

Sample apps changed error.stack ? error.stack : error to error.stack ?? error, which changes
behavior when error.stack is an empty string. In that case the new code logs an empty string
instead of the error object, reducing debugging output.

Code

sample/sample10-mixed/app.ts[54]

+            .catch((error) => console.log(error.stack ?? error))

Evidence

The new logging uses nullish coalescing. Unlike the previous truthiness check, ?? will not fall
back when error.stack is "" (empty string).

sample/sample10-mixed/app.ts[51-56]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`error.stack ?? error` differs from the previous `error.stack ? error.stack : error` when `error.stack` is an empty string.
## Issue Context
This only affects sample apps and is an edge case, but it can reduce log usefulness.
## Fix Focus Areas
- sample/sample10-mixed/app.ts[51-56]
## Suggested change
If you want to preserve the old behavior, use a truthy check:

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools