Skip to content

ci(qodo): add optional chaining compliance rule #12255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pkuczynski wants to merge 3 commits into from
Closed

ci(qodo): add optional chaining compliance rule #12255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d731fae
ci(qodo): add optional chaining compliance rule
Mar 22, 2026
e8e4aa9
Merge remote-tracking branch 'origin/master' into chore/optional-chai…
pkuczynski Mar 29, 2026
b0a81dc
fix(qodo): refine optional chaining rule to exempt mutation and accep…
pkuczynski Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pr_compliance_checklist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ pr_compliances:
success_criteria: "All identifiers follow the established naming patterns (camelCase, PascalCase, snake_case, etc.)"
failure_criteria: "Inconsistent or non-standard naming that deviates from project conventions"

- title: "Prefer optional chaining over non-null assertions in test assertions"
compliance_label: true
objective: "Test property access in assertions should use optional chaining (?.) instead of non-null assertions (!). Non-null assertions remain acceptable for mutation or passing values to functions (e.g. repo.save(x!))."
success_criteria: "Test assertions verify non-null (expect(x).to.not.be.null or expect(x).not.to.be.null) then access properties with optional chaining (x?.property). Iteration asserts array length before looping rather than defaulting to an empty array."
failure_criteria: "Tests use result!.property for read-only access in assertions where optional chaining would suffice."

- title: "Remove AI-generated noise"
compliance_label: true
objective: "Changes should not introduce AI-generated slop."
Expand Down
Loading