Skip to content

ci: bump actions/setup-node to v5 and benefit from automatic caching#11709

Merged
naorpeled merged 1 commit intotypeorm:masterfrom
pkuczynski:ci/setup-node
Oct 3, 2025
Merged

ci: bump actions/setup-node to v5 and benefit from automatic caching#11709
naorpeled merged 1 commit intotypeorm:masterfrom
pkuczynski:ci/setup-node

Conversation

@pkuczynski
Copy link
Collaborator

@pkuczynski pkuczynski commented Oct 2, 2025

Description of change

Simplifies CI setup and ensures future GHA compatibility.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • This pull request links relevant issues as Fixes #00000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change

Summary by CodeRabbit

  • Chores

    • Upgraded the Node.js setup action used across CI workflows to the latest version, improving reliability and compatibility.
    • Removed the npm cache option from CI to simplify configuration and reduce potential inconsistencies.
    • Added a package configuration to standardize npm as the development package manager, enforcing consistent tooling behavior across environments.
  • Tests

    • CI test workflows updated to use the latest Node.js setup action, with no changes to test coverage or logic.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Walkthrough

Updates GitHub Actions workflows to use actions/setup-node@v5 and removes npm caching options. Adds a new devEngines.packageManager configuration in package.json. No other flow or logic changes are introduced.

Changes

Cohort / File(s) Summary
CI Node setup upgrade
.github/workflows/commit-validation.yml, .github/workflows/preview.yml, .github/workflows/publish-package.yml, .github/workflows/tests-linux.yml, .github/workflows/tests-windows.yml
Bump actions/setup-node from v4 to v5 and remove cache: "npm" entries; workflows otherwise unchanged.
Package metadata
package.json
Add root devEngines.packageManager config: { name: "npm", onFail: "error" }.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • OSA413
  • naorpeled
  • sgarner
  • gioboa

Poem

I nibbled through workflows, hop by hop,
Swapped Node steps to v5—clean sweep, non-stop.
Cached crumbs gone, the path runs clear,
Dev engines hum with npm gear.
Thump-thump! CI’s tidy and spry—
A happy hare beneath the sky. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit's high-level summary is enabled.
Title Check ✅ Passed The title succinctly and accurately summarizes the primary change of the pull request—upgrading actions/setup-node to v5 to leverage built-in caching—and is specific and concise enough to convey the main intent without generic or off-topic terms.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2446bd0 and 24c4821.

📒 Files selected for processing (6)
  • .github/workflows/commit-validation.yml (2 hunks)
  • .github/workflows/preview.yml (1 hunks)
  • .github/workflows/publish-package.yml (1 hunks)
  • .github/workflows/tests-linux.yml (11 hunks)
  • .github/workflows/tests-windows.yml (3 hunks)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
  • GitHub Check: tests-linux (20) / postgres (17)
  • GitHub Check: tests-linux (20) / postgres (14)
  • GitHub Check: tests-linux (20) / mongodb
  • GitHub Check: tests-linux (18) / postgres (17)
  • GitHub Check: tests-linux (20) / cockroachdb
  • GitHub Check: tests-linux (18) / postgres (14)
  • GitHub Check: tests-linux (18) / mssql
  • GitHub Check: tests-linux (18) / sqlite
  • GitHub Check: tests-linux (18) / better-sqlite3
  • GitHub Check: tests-linux (18) / sqljs
  • GitHub Check: tests-linux (18) / oracle
  • GitHub Check: tests-linux (18) / mongodb
  • GitHub Check: tests-linux (18) / mysql_mariadb
  • GitHub Check: tests-linux (18) / mysql_mariadb_latest
  • GitHub Check: tests-windows / sqlite
  • GitHub Check: tests-windows / sqljs
  • GitHub Check: tests-windows / better-sqlite3
  • GitHub Check: Analyze (javascript-typescript)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 2, 2025

typeorm-sql-js-example

npm i https://pkg.pr.new/typeorm/typeorm@11709

commit: 24c4821

@coveralls
Copy link

Coverage Status

coverage: 76.431%. remained the same
when pulling 24c4821 on pkuczynski:ci/setup-node
into 2446bd0 on typeorm:master.

Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's amazing 🤩
Thank you @pkuczynski

@gioboa gioboa requested review from alumni and naorpeled October 3, 2025 06:33
@naorpeled naorpeled merged commit dbfaad9 into typeorm:master Oct 3, 2025
62 checks passed
@pkuczynski pkuczynski deleted the ci/setup-node branch October 3, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments