Skip to content

Fix(undefined-null-flags): Handle null for relations #11398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jovanadjuric merged 3 commits into from
Apr 9, 2025
Merged

Fix(undefined-null-flags): Handle null for relations #11398

jovanadjuric merged 3 commits into from
Apr 9, 2025

Conversation

@jovanadjuric
Copy link
Contributor

@jovanadjuric jovanadjuric commented Apr 7, 2025

Description of change

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@jovanadjuric jovanadjuric requested a review from naorpeled April 7, 2025 21:38
@alenap93
Copy link
Contributor

alenap93 commented Apr 8, 2025

I think that this PR has many breaking changes

@jovanadjuric
Copy link
Contributor Author

jovanadjuric commented Apr 8, 2025 •
edited
Loading

I think that this PR has many breaking changes

Hey @alienap93, thanks for your feedback!

Would you care to elaborate? As far as I can tell, no breaking changes are featured here. The parent PR is still a draft, and it will need quite a bit of testing before we merge it to master anyway.

  • The new else-if blocks in QueryBuilder.ts are only executed if the feature flags are set to true. Otherwise, the return statement at the bottom of the method will catch all unhandled cases, just like it did before
  • I moved the if block on SelectQueryBuilder.ts:4385 up as it was unreachable because typeof null === "object" evaluates to true

Let me know if I missed something 👀

naorpeled
naorpeled approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@naorpeled naorpeled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you ❤️

@jovanadjuric jovanadjuric merged commit bdad413 into typeorm:feat/add-undefined-and-null-flags Apr 9, 2025
@jovanadjuric jovanadjuric deleted the fix/handle-null branch April 9, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naorpeled naorpeled naorpeled approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jovanadjuric @alenap93 @naorpeled