Fixes #10687 - regression caused by #10273. Changing PRAGMA queries back to use query() instead of run() #10774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… back to .run() instead of .query() for all PRAGMA calls.
18 tasks
5 tasks
alumni
approved these changes
May 13, 2025
gioboa
approved these changes
May 13, 2025
Collaborator
gioboa
requested changes
May 14, 2025
Collaborator
gioboa
left a comment
gioboa
left a comment
There was a problem hiding this comment.
@gioboa we don't have tests for capacitor.
Shall we merge this or #11467?
🤔 I found this statement in the capacitor API docs
SQLite Special commands (PRAGMA) should be executed using the execute plugin method.
Collaborator
|
@gioboa see the other pr |
Collaborator
Yep, the other PR seems aligned with the capacitor docs |
Collaborator
|
Ok, I already approved both PRs recently, so we can merge one of them |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent MR #10273 included some unnecessary changes that made SQLite PRAGMA queries be executed using
connection.runinstead ofconnection.query.This causes the bug reported in #10687
This MR simply reverts a small part of #10273 to go back to the previous working behavior.