Support [email protected] as peer dependency #9563
Description
Feature Description
The Problem
Running an evergreen environment leads into an npm install error when [email protected] should be used.
Recently better-sqlite3 released version 8.0.0 which does not match the peer-dependency version range defined in the packge.json file here.
However: Version 8.0.0's only breaking change is the dropped support of node.js version 10.x.x.
The Solution
The peerDependency definition in the packge.json file here for [email protected] should be changed to:
// ...
"peerDependencies": {
// ...
"better-sqlite3": "^7.1.2 || ^8.0.0",
}As the node engine defined in typeorm is set to a minimum of 12.9.0 this change should be save.
Considered Alternatives
Additional Context
Relevant Database Driver(s)
| DB Type | Relevant |
|---|---|
aurora-mysql |
no |
aurora-postgres |
no |
better-sqlite3 |
yes |
cockroachdb |
no |
cordova |
no |
expo |
no |
mongodb |
no |
mysql |
no |
nativescript |
no |
oracle |
no |
postgres |
no |
react-native |
no |
sap |
no |
spanner |
no |
sqlite |
no |
sqlite-abstract |
no |
sqljs |
no |
sqlserver |
no |
Are you willing to resolve this issue by submitting a Pull Request?
- ✅ Yes, I have the time, and I know how to start.
- ✖️ Yes, I have the time, but I don't know how to start. I would need guidance.
- ✖️ No, I don’t have the time, but I can support (using donations) development.
- ✖️ No, I don’t have the time and I’m okay to wait for the community / maintainers to resolve this issue.