Skip to content

Persist column comments on SAP HANA #10501

@alumni

Description

@alumni

Feature Description

When a comment is added to the Column decorator options, TypeORM should use it when generating the database structure in SAP HANA.

The Solution

The CREATE TABLE / ALTER TABLE statements should contain the correct COMMENT clause when there is a comment configured for a column. When changing an entity, if the only change in a column is the comment, a COMMENT statement can be used.

Considered Alternatives

The Postgres driver has an implementation of column comments.

Additional Context

No response

Relevant Database Driver(s)

  • aurora-mysql
  • aurora-postgres
  • better-sqlite3
  • cockroachdb
  • cordova
  • expo
  • mongodb
  • mysql
  • nativescript
  • oracle
  • postgres
  • react-native
  • sap
  • spanner
  • sqlite
  • sqlite-abstract
  • sqljs
  • sqlserver

Are you willing to resolve this issue by submitting a Pull Request?

Yes, I have the time, and I know how to start.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions