-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Closed
Labels
Description
Issue description
logMigration
Expected Behavior
with custom logger, when migration execution failed, should call logMigration method.
Actual Behavior
There is no error log of migration type for migration error.
Steps to reproduce
// migration
export class FailMigration1530542855524 implements MigrationInterface {
public async up(queryRunner: QueryRunner): Promise<void> {
throw new Error("migration error")
}
public async down(queryRunner: QueryRunner): Promise<void> {
throw new Error("migration error")
}
}
// TestLogger
class TestLogger extends AbstractLogger {
protected writeLog(
level: LogLevel,
logMessage: LogMessage | LogMessage[],
queryRunner?: QueryRunner,
) {
const messages = this.prepareLogMessages(logMessage, {
highlightSql: false,
})
for (let message of messages) {
switch (message.type ?? level) {
case "migration":
console.log(message.message)
break
}
}
}
}
when run migration, it must be failed. but there is no
My Environment
| Dependency | Version |
|---|---|
| Operating System | |
| Node.js version | 16.y.zzz |
| Typescript version | 5.y.zzz |
| TypeORM version | 0.3.16 |
Additional Context
No response
Relevant Database Driver(s)
- aurora-mysql
- aurora-postgres
- better-sqlite3
- cockroachdb
- cordova
- expo
- mongodb
- mysql
- nativescript
- oracle
- postgres
- react-native
- sap
- spanner
- sqlite
- sqlite-abstract
- sqljs
- sqlserver
Are you willing to resolve this issue by submitting a Pull Request?
Yes, I have the time, and I know how to start.