perf(query-runner): use Date.now() intead of +new Date() (#10811)

Samuron · alumni · mguida22 · web-flow · commit fe71a0c3e441 · 2025-04-15T13:18:22.000-06:00
* perf(query-runner): use Date.now() intead of +new Date()

* perf: use Date.now() instead of new Date().getTime()

---------

Co-authored-by: Lucian Mocanu &lt;alumni@users.noreply.github.com&gt;
Co-authored-by: Mike Guida &lt;mike@mguida.com&gt;
diff --git a/src/cache/DbQueryResultCache.ts b/src/cache/DbQueryResultCache.ts
@@ -201,7 +201,7 @@ export class DbQueryResultCache implements QueryResultCache {
                 ? parseInt(savedCache.time as any)
                 : savedCache.time)! +
                 duration <
-            new Date().getTime()
+            Date.now()
         )
     }
 
diff --git a/src/cache/RedisQueryResultCache.ts b/src/cache/RedisQueryResultCache.ts
@@ -152,7 +152,7 @@ export class RedisQueryResultCache implements QueryResultCache {
      * Checks if cache is expired or not.
      */
     isExpired(savedCache: QueryResultCacheOptions): boolean {
-        return savedCache.time! + savedCache.duration < new Date().getTime()
+        return savedCache.time! + savedCache.duration < Date.now()
     }
 
     /**
diff --git a/src/driver/better-sqlite3/BetterSqlite3QueryRunner.ts b/src/driver/better-sqlite3/BetterSqlite3QueryRunner.ts
@@ -92,7 +92,7 @@ export class BetterSqlite3QueryRunner extends AbstractSqliteQueryRunner {
             query,
             parameters,
         )
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
 
         const stmt = await this.getStmt(query)
 
@@ -116,7 +116,7 @@ export class BetterSqlite3QueryRunner extends AbstractSqliteQueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
             if (
                 maxQueryExecutionTime &&
diff --git a/src/driver/cockroachdb/CockroachQueryRunner.ts b/src/driver/cockroachdb/CockroachQueryRunner.ts
@@ -279,7 +279,7 @@ export class CockroachQueryRunner
             parameters,
         )
 
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
 
         if (this.isTransactionActive && this.storeQueries) {
             this.queries.push({ query, parameters })
@@ -297,7 +297,7 @@ export class CockroachQueryRunner
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
             if (
                 maxQueryExecutionTime &&
diff --git a/src/driver/cordova/CordovaQueryRunner.ts b/src/driver/cordova/CordovaQueryRunner.ts
@@ -62,7 +62,7 @@ export class CordovaQueryRunner extends AbstractSqliteQueryRunner {
             parameters,
         )
 
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
 
         try {
             const raw = await new Promise<any>(async (ok, fail) => {
@@ -77,7 +77,7 @@ export class CordovaQueryRunner extends AbstractSqliteQueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/expo/ExpoQueryRunner.ts b/src/driver/expo/ExpoQueryRunner.ts
@@ -41,15 +41,15 @@ export class ExpoQueryRunner extends AbstractSqliteQueryRunner {
             parameters,
         )
 
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
 
         const statement = await databaseConnection.prepareAsync(query)
         try {
             const rawResult = await statement.executeAsync(parameters)
 
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/expo/legacy/ExpoLegacyQueryRunner.ts b/src/driver/expo/legacy/ExpoLegacyQueryRunner.ts
@@ -174,7 +174,7 @@ export class ExpoLegacyQueryRunner extends AbstractSqliteQueryRunner {
                 parameters,
             )
 
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             // All Expo SQL queries are executed in a transaction context
             databaseConnection.transaction(
                 async (transaction: ITransaction) => {
@@ -189,7 +189,7 @@ export class ExpoLegacyQueryRunner extends AbstractSqliteQueryRunner {
                             // log slow queries if maxQueryExecution time is set
                             const maxQueryExecutionTime =
                                 this.driver.options.maxQueryExecutionTime
-                            const queryEndTime = +new Date()
+                            const queryEndTime = Date.now()
                             const queryExecutionTime =
                                 queryEndTime - queryStartTime
 
diff --git a/src/driver/mysql/MysqlQueryRunner.ts b/src/driver/mysql/MysqlQueryRunner.ts
@@ -207,15 +207,15 @@ export class MysqlQueryRunner extends BaseQueryRunner implements QueryRunner {
                     enableQueryTimeout && maxQueryExecutionTime
                         ? { sql: query, timeout: maxQueryExecutionTime }
                         : query
-                const queryStartTime = +new Date()
+                const queryStartTime = Date.now()
                 databaseConnection.query(
                     queryPayload,
                     parameters,
                     async (err: any, raw: any) => {
                         // log slow queries if maxQueryExecution time is set
                         const maxQueryExecutionTime =
                             this.driver.options.maxQueryExecutionTime
-                        const queryEndTime = +new Date()
+                        const queryEndTime = Date.now()
                         const queryExecutionTime = queryEndTime - queryStartTime
 
                         if (
diff --git a/src/driver/nativescript/NativescriptQueryRunner.ts b/src/driver/nativescript/NativescriptQueryRunner.ts
@@ -63,7 +63,7 @@ export class NativescriptQueryRunner extends AbstractSqliteQueryRunner {
                 // log slow queries if maxQueryExecution time is set
                 const maxQueryExecutionTime =
                     this.driver.options.maxQueryExecutionTime
-                const queryEndTime = +new Date()
+                const queryEndTime = Date.now()
                 const queryExecutionTime = queryEndTime - queryStartTime
 
                 if (
@@ -101,7 +101,7 @@ export class NativescriptQueryRunner extends AbstractSqliteQueryRunner {
                     ok(result.raw)
                 }
             }
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
 
             if (isInsertQuery) {
                 databaseConnection.execSQL(query, parameters, handler)
diff --git a/src/driver/oracle/OracleQueryRunner.ts b/src/driver/oracle/OracleQueryRunner.ts
@@ -207,7 +207,7 @@ export class OracleQueryRunner extends BaseQueryRunner implements QueryRunner {
             parameters,
         )
 
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
 
         try {
             const executionOptions = {
@@ -224,7 +224,7 @@ export class OracleQueryRunner extends BaseQueryRunner implements QueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/postgres/PostgresQueryRunner.ts b/src/driver/postgres/PostgresQueryRunner.ts
@@ -253,12 +253,12 @@ export class PostgresQueryRunner
         )
 
         try {
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             const raw = await databaseConnection.query(query, parameters)
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/react-native/ReactNativeQueryRunner.ts b/src/driver/react-native/ReactNativeQueryRunner.ts
@@ -63,15 +63,15 @@ export class ReactNativeQueryRunner extends AbstractSqliteQueryRunner {
                 parameters,
             )
 
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             databaseConnection.executeSql(
                 query,
                 parameters,
                 async (raw: any) => {
                     // log slow queries if maxQueryExecution time is set
                     const maxQueryExecutionTime =
                         this.driver.options.maxQueryExecutionTime
-                    const queryEndTime = +new Date()
+                    const queryEndTime = Date.now()
                     const queryExecutionTime = queryEndTime - queryStartTime
 
                     this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/sap/SapQueryRunner.ts b/src/driver/sap/SapQueryRunner.ts
@@ -207,7 +207,7 @@ export class SapQueryRunner extends BaseQueryRunner implements QueryRunner {
                 parameters,
             )
 
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             const isInsertQuery = query.substr(0, 11) === "INSERT INTO"
 
             if (parameters?.some(Array.isArray)) {
@@ -232,7 +232,7 @@ export class SapQueryRunner extends BaseQueryRunner implements QueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.connection.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/driver/spanner/SpannerQueryRunner.ts b/src/driver/spanner/SpannerQueryRunner.ts
@@ -159,7 +159,7 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {
         const broadcasterResult = new BroadcasterResult()
 
         try {
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             await this.connect()
             let rawResult:
                 | [
@@ -216,7 +216,7 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             this.broadcaster.broadcastAfterQueryEvent(
@@ -286,15 +286,15 @@ export class SpannerQueryRunner extends BaseQueryRunner implements QueryRunner {
 
         this.driver.connection.logger.logQuery(query, parameters, this)
         try {
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
             const [operation] = await this.driver.instanceDatabase.updateSchema(
                 query,
             )
             await operation.promise()
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
             if (
                 maxQueryExecutionTime &&
diff --git a/src/driver/sqlite/SqliteQueryRunner.ts b/src/driver/sqlite/SqliteQueryRunner.ts
@@ -75,7 +75,7 @@ export class SqliteQueryRunner extends AbstractSqliteQueryRunner {
             try {
                 const databaseConnection = await this.connect()
                 this.driver.connection.logger.logQuery(query, parameters, this)
-                const queryStartTime = +new Date()
+                const queryStartTime = Date.now()
                 const isInsertQuery = query.startsWith("INSERT ")
                 const isDeleteQuery = query.startsWith("DELETE ")
                 const isUpdateQuery = query.startsWith("UPDATE ")
@@ -101,7 +101,7 @@ export class SqliteQueryRunner extends AbstractSqliteQueryRunner {
                     }
 
                     // log slow queries if maxQueryExecution time is set
-                    const queryEndTime = +new Date()
+                    const queryEndTime = Date.now()
                     const queryExecutionTime = queryEndTime - queryStartTime
                     if (
                         maxQueryExecutionTime &&
diff --git a/src/driver/sqljs/SqljsQueryRunner.ts b/src/driver/sqljs/SqljsQueryRunner.ts
@@ -94,7 +94,7 @@ export class SqljsQueryRunner extends AbstractSqliteQueryRunner {
             parameters,
         )
 
-        const queryStartTime = +new Date()
+        const queryStartTime = Date.now()
         let statement: any
         try {
             statement = databaseConnection.prepare(query)
@@ -109,7 +109,7 @@ export class SqljsQueryRunner extends AbstractSqliteQueryRunner {
             // log slow queries if maxQueryExecution time is set
             const maxQueryExecutionTime =
                 this.driver.options.maxQueryExecutionTime
-            const queryEndTime = +new Date()
+            const queryEndTime = Date.now()
             const queryExecutionTime = queryEndTime - queryStartTime
 
             if (
diff --git a/src/driver/sqlserver/SqlServerQueryRunner.ts b/src/driver/sqlserver/SqlServerQueryRunner.ts
@@ -245,14 +245,14 @@ export class SqlServerQueryRunner
                     }
                 })
             }
-            const queryStartTime = +new Date()
+            const queryStartTime = Date.now()
 
             const raw = await new Promise<any>((ok, fail) => {
                 request.query(query, (err: any, raw: any) => {
                     // log slow queries if maxQueryExecution time is set
                     const maxQueryExecutionTime =
                         this.driver.options.maxQueryExecutionTime
-                    const queryEndTime = +new Date()
+                    const queryEndTime = Date.now()
                     const queryExecutionTime = queryEndTime - queryStartTime
 
                     this.broadcaster.broadcastAfterQueryEvent(
diff --git a/src/query-builder/SelectQueryBuilder.ts b/src/query-builder/SelectQueryBuilder.ts
@@ -3810,7 +3810,7 @@ export class SelectQueryBuilder<Entity extends ObjectLiteral>
                     {
                         identifier: this.expressionMap.cacheId,
                         query: queryId,
-                        time: new Date().getTime(),
+                        time: Date.now(),
                         duration:
                             this.expressionMap.cacheDuration ||
                             cacheOptions.duration ||
diff --git a/test/functional/cache/provider/MockQueryResultCache.ts b/test/functional/cache/provider/MockQueryResultCache.ts
@@ -190,7 +190,7 @@ export class MockQueryResultCache implements QueryResultCache {
                 ? parseInt(savedCache.time as any)
                 : savedCache.time)! +
                 duration <
-            new Date().getTime()
+            Date.now()
         )
     }
 

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ export class DbQueryResultCache implements QueryResultCache {`
`201`	`201`	`? parseInt(savedCache.time as any)`
`202`	`202`	`: savedCache.time)! +`
`203`	`203`	`duration <`
`204`		`- new Date().getTime()`
	`204`	`+ Date.now()`
`205`	`205`	`)`
`206`	`206`	`}`
`207`	`207`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ export class RedisQueryResultCache implements QueryResultCache {`
`152`	`152`	`* Checks if cache is expired or not.`
`153`	`153`	`*/`
`154`	`154`	`isExpired(savedCache: QueryResultCacheOptions): boolean {`
`155`		`- return savedCache.time! + savedCache.duration < new Date().getTime()`
	`155`	`+ return savedCache.time! + savedCache.duration < Date.now()`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`/**`