Skip to content

Commit d731fae

Browse files
author
TypeORM Review
committed
ci(qodo): add optional chaining compliance rule
1 parent 7038fa1 commit d731fae

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎pr_compliance_checklist.yaml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,12 @@ pr_compliances:
1717
success_criteria: "All identifiers follow the established naming patterns (camelCase, PascalCase, snake_case, etc.)"
1818
failure_criteria: "Inconsistent or non-standard naming that deviates from project conventions"
1919

20+
- title: "Prefer optional chaining over non-null assertions in tests"
21+
compliance_label: true
22+
objective: "Tests should use optional chaining (?.) instead of non-null assertions (!) after null checks."
23+
success_criteria: "Test assertions use expect(result).to.not.be.null followed by result?.property and result?.items ?? [] for iteration."
24+
failure_criteria: "Tests use result!.property or result!.items non-null assertions after null checks."
25+
2026
- title: "Remove AI-generated noise"
2127
compliance_label: true
2228
objective: "Changes should not introduce AI-generated slop."

0 commit comments

Comments
 (0)