Skip to content

Commit 3860eb0

Browse files
committed
fix(test): replace non-null assertions with optional chaining per SonarQube feedback
1 parent 3b72167 commit 3860eb0

2 files changed

Lines changed: 12 additions & 9 deletions

File tree

‎test/functional/columns/value-transformer/value-transformer.test.ts‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,8 +151,9 @@ describe("columns > value-transformer functionality", () => {
151151
"complex",
152152
"actually",
153153
])
154-
expect(loadedPost.complex!.x).to.eq(3)
155-
expect(loadedPost.complex!.y).to.eq(2.5)
154+
expect(loadedPost.complex).to.not.be.null
155+
expect(loadedPost.complex?.x).to.eq(3)
156+
expect(loadedPost.complex?.y).to.eq(2.5)
156157

157158
// then update all its properties and save again
158159
post.title = "Complex transformers3!"
@@ -174,8 +175,9 @@ describe("columns > value-transformer functionality", () => {
174175
loadedPost = await postRepository.findOneByOrFail({
175176
id: post.id,
176177
})
177-
expect(loadedPost.complex!.x).to.eq(0.5)
178-
expect(loadedPost.complex!.y).to.eq(0.5)
178+
expect(loadedPost.complex).to.not.be.null
179+
expect(loadedPost.complex?.x).to.eq(0.5)
180+
expect(loadedPost.complex?.y).to.eq(0.5)
179181

180182
// then update all its properties and save again
181183
post.title = "Complex transformers5!"
@@ -186,8 +188,9 @@ describe("columns > value-transformer functionality", () => {
186188
loadedPost = await postRepository.findOneByOrFail({
187189
id: post.id,
188190
})
189-
expect(loadedPost.complex!.x).to.eq(1.05)
190-
expect(loadedPost.complex!.y).to.eq(2.3)
191+
expect(loadedPost.complex).to.not.be.null
192+
expect(loadedPost.complex?.x).to.eq(1.05)
193+
expect(loadedPost.complex?.y).to.eq(2.3)
191194
}),
192195
))
193196
})

‎test/functional/mongodb/basic/embedded-columns-listeners/mongodb-embedded-columns-listeners.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ describe("mongodb > embedded columns listeners", () => {
5353
})
5454

5555
expect(loadedUpdatedPost.counters).to.be.not.empty
56-
expect(loadedUpdatedPost.counters!.likes).to.be.eq(100)
56+
expect(loadedUpdatedPost.counters?.likes).to.be.eq(100)
5757
expect(
58-
loadedUpdatedPost.counters!.information!.comments,
58+
loadedUpdatedPost.counters?.information?.comments,
5959
).to.be.eq(1)
60-
expect(loadedUpdatedPost.counters!.information!.description).to
60+
expect(loadedUpdatedPost.counters?.information?.description).to
6161
.be.not.empty
6262
loadedUpdatedPost.should.be.instanceOf(Post)
6363
loadedUpdatedPost.title.should.be.equal("Updated post")

0 commit comments

Comments
 (0)