fix: make cache optional fields optional (#9942)

RustySol · web-flow · commit 159c60a6e8ce · 2023-04-15T14:47:12.000+05:00
This patch allows the getFromCache caller to only pass in
identifier or query field, as getFromCache already handles
the identifier and query field checks

Co-authored-by: ru.c &lt;ru@shuffle.com&gt;
diff --git a/src/cache/DbQueryResultCache.ts b/src/cache/DbQueryResultCache.ts
@@ -131,7 +131,7 @@ export class DbQueryResultCache implements QueryResultCache {
     }
 
     /**
-     * Caches given query result.
+     * Get data from cache.
      * Returns cache result if found.
      * Returns undefined if result is not cached.
      */
diff --git a/src/cache/QueryResultCacheOptions.ts b/src/cache/QueryResultCacheOptions.ts
@@ -6,7 +6,7 @@ export interface QueryResultCacheOptions {
      * Cache identifier set by user.
      * Can be empty.
      */
-    identifier: string
+    identifier?: string
 
     /**
      * Time, when cache was created.
@@ -21,7 +21,7 @@ export interface QueryResultCacheOptions {
     /**
      * Cached query.
      */
-    query: string
+    query?: string
 
     /**
      * Query result that will be cached.
diff --git a/src/cache/RedisQueryResultCache.ts b/src/cache/RedisQueryResultCache.ts
@@ -123,7 +123,7 @@ export class RedisQueryResultCache implements QueryResultCache {
     async synchronize(queryRunner: QueryRunner): Promise<void> {}
 
     /**
-     * Caches given query result.
+     * Get data from cache.
      * Returns cache result if found.
      * Returns undefined if result is not cached.
      */

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ export class DbQueryResultCache implements QueryResultCache {`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`/**`
`134`		`- * Caches given query result.`
	`134`	`+ * Get data from cache.`
`135`	`135`	`* Returns cache result if found.`
`136`	`136`	`* Returns undefined if result is not cached.`
`137`	`137`	`*/`