fix: aggregate function throw error when column alias name is set (#10035)

shenX-2021 · web-flow · commit 022d2b5f6227 · 2023-08-19T20:52:03.000+05:00
* fix: aggregate function throw error when column alias name is set Closes: #9927
diff --git a/src/entity-manager/EntityManager.ts b/src/entity-manager/EntityManager.ts
@@ -1054,11 +1054,20 @@ export class EntityManager {
         where: FindOptionsWhere<Entity> | FindOptionsWhere<Entity>[] = {},
     ): Promise<number | null> {
         const metadata = this.connection.getMetadata(entityClass)
+        const column = metadata.columns.find(
+            (item) => item.propertyPath === columnName,
+        )
+        if (!column) {
+            throw new TypeORMError(
+                `Column "${columnName}" was not found in table "${metadata.name}"`,
+            )
+        }
+
         const result = await this.createQueryBuilder(entityClass, metadata.name)
             .setFindOptions({ where })
             .select(
                 `${fnName}(${this.connection.driver.escape(
-                    String(columnName),
+                    column.databaseName,
                 )})`,
                 fnName,
             )
diff --git a/test/github-issues/9927/entity/ExampleEntity.ts b/test/github-issues/9927/entity/ExampleEntity.ts
@@ -0,0 +1,17 @@
+import { Entity } from "../../../../src/decorator/entity/Entity"
+import { Column } from "../../../../src/decorator/columns/Column"
+import { PrimaryGeneratedColumn } from "../../../../src/decorator/columns/PrimaryGeneratedColumn"
+
+@Entity()
+export class ExampleEntity {
+    @PrimaryGeneratedColumn()
+    id: number
+
+    @Column({
+        type: "int",
+        name: "serial_no_id",
+        nullable: false,
+        default: 0,
+    })
+    serialNoId: number
+}
diff --git a/test/github-issues/9927/issue-9927.ts b/test/github-issues/9927/issue-9927.ts
@@ -0,0 +1,65 @@
+import { DataSource } from "../../../src"
+import {
+    closeTestingConnections,
+    createTestingConnections,
+    reloadTestingDatabases,
+} from "../../utils/test-utils"
+import { ExampleEntity } from "./entity/ExampleEntity"
+
+describe("github issues > #9927 aggregate function throw error when column alias name is set", () => {
+    let dataSources: DataSource[]
+
+    before(async () => {
+        dataSources = await createTestingConnections({
+            entities: [ExampleEntity],
+            enabledDrivers: ["mariadb"],
+        })
+    })
+
+    beforeEach(() => reloadTestingDatabases(dataSources))
+    after(() => closeTestingConnections(dataSources))
+
+    it("should call `maximum` method successfully", async () => {
+        await Promise.all(
+            dataSources.map(async (dataSource) => {
+                await dataSource.manager.maximum(
+                    ExampleEntity,
+                    "serialNoId",
+                    {},
+                )
+            }),
+        )
+    })
+
+    it("should call `minimum` method successfully", async () => {
+        await Promise.all(
+            dataSources.map(async (dataSource) => {
+                await dataSource.manager.minimum(
+                    ExampleEntity,
+                    "serialNoId",
+                    {},
+                )
+            }),
+        )
+    })
+
+    it("should call `sum` method successfully", async () => {
+        await Promise.all(
+            dataSources.map(async (dataSource) => {
+                await dataSource.manager.sum(ExampleEntity, "serialNoId", {})
+            }),
+        )
+    })
+
+    it("should call `average` method successfully", async () => {
+        await Promise.all(
+            dataSources.map(async (dataSource) => {
+                await dataSource.manager.average(
+                    ExampleEntity,
+                    "serialNoId",
+                    {},
+                )
+            }),
+        )
+    })
+})
