Skip to content

Upgrade Scala.js to 1.0.0#620

Merged
ashawley merged 3 commits intotypelevel:masterfrom
xerial:scalajs1.0.0
Feb 8, 2020
Merged

Upgrade Scala.js to 1.0.0#620
ashawley merged 3 commits intotypelevel:masterfrom
xerial:scalajs1.0.0

Conversation

@xerial
Copy link
Copy Markdown
Contributor

@xerial xerial commented Feb 5, 2020

@ashawley
Copy link
Copy Markdown
Contributor

ashawley commented Feb 5, 2020

Would you be willing to update the Scala.js example to 1.0 while you're at it?

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 5, 2020

Sure. Let me try :)

@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 5, 2020

@ashawley Done. The next target version is 1.14.3 or 1.15.0?

@ashawley
Copy link
Copy Markdown
Contributor

ashawley commented Feb 5, 2020

Thanks!

The current version is 1.14.3, the next version will be 1.15.0.

We can look in to backporting to 1.14.x and pushing a tag like we did most recently in #592, for example.

@ashawley
Copy link
Copy Markdown
Contributor

ashawley commented Feb 5, 2020

LGTM! The mima check fails because 1.14.3 artifacts don't exist, but we can resolve that as I mentioned previously.

@larsrh
Copy link
Copy Markdown
Contributor

larsrh commented Feb 7, 2020

It would be great if you could release 1.14.3 with sjs 1.0 support. That way, it wouldn't trigger a wave of version bumps across the ecosystem.

@ashawley
Copy link
Copy Markdown
Contributor

ashawley commented Feb 8, 2020

Yes, that's what is being worked on in #623.

@ashawley
Copy link
Copy Markdown
Contributor

ashawley commented Feb 8, 2020

1.14.3 artifacts for Scala.js have been released.

@ashawley ashawley merged commit cddf22f into typelevel:master Feb 8, 2020
@xerial
Copy link
Copy Markdown
Contributor Author

xerial commented Feb 8, 2020

@ashawley Awesome. Thank you so much 😄

@ashawley ashawley removed this from the 1.15.0 milestone Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants