Merged
Conversation
mpilquist
commented
Sep 3, 2025
| binding.read(engine.getSession.getPacketBufferSize).flatMap { | ||
| case Some(c) => unwrapBuffer.input(c) >> unwrapHandshake | ||
| case None => | ||
| unwrapBuffer.inputRemains |
Member
Author
There was a problem hiding this comment.
If we've reached this point, and there's data in unwrapBuffer, then we know the last handshake status was BUFFER_UNDERFLOW and we've read no data that can help progress the handshake.
Since binding.read has returned a None, we'll never get more data from the socket. Doing nothing will result in the infinite loop from the original bug report. To fix, we just terminate the handshake (via stopUnwrap).
matthughes
approved these changes
Sep 3, 2025
…dshake to peg a server cpu
mpilquist
added a commit
that referenced
this pull request
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a spinloop bug where an aborted TLS handshake can result in TLSEngine consuming a CPU.
Initially reported by @matthughes.