Use interruptible in writeOutputStream#2932
Merged
mpilquist merged 3 commits intotypelevel:mainfrom Jul 1, 2022
Merged
Conversation
Member
|
Fwiw, in this type of thing, I suspect the overhead of |
diesalbla
approved these changes
Jun 26, 2022
Member
|
FYI, I pulled this into my original non-minimized reproduction locally and it looks like it resolves the issue. Thanks for digging into it so quickly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2931.
As I understand it, interruptibility doesn't come for free. How do we feel about placing it in the hot path here? Maybe it should be configurable?