Implement TLSSocket#applicationProtocol on JS#2741
Merged
mpilquist merged 3 commits intotypelevel:mainfrom Dec 5, 2021
Merged
Conversation
13 tasks
Member
ChristopherDavenport
left a comment
ChristopherDavenport
left a comment
There was a problem hiding this comment.
👍 This looks good to me and gets js into parity. Might want to note that null from before will now end up as NoSuchElement exceptions somewhere. I already moved to handle this, but its possible someone else was coding against this and should know for an upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.