Flush CharsetDecoder to produce final chunk#2667
Merged
mpilquist merged 2 commits intotypelevel:mainfrom Oct 6, 2021
rossabaker:issue-2664
Merged
Flush CharsetDecoder to produce final chunk#2667mpilquist merged 2 commits intotypelevel:mainfrom rossabaker:issue-2664
mpilquist merged 2 commits intotypelevel:mainfrom
rossabaker:issue-2664
Conversation
mpilquist
reviewed
Oct 5, 2021
| decoder.flush(out) match { | ||
| case res if res.isUnderflow => | ||
| if (out.position() > 0) { | ||
| out.flip() |
Member
There was a problem hiding this comment.
I think we need a (out: Buffer).flip() here to maintain JDK8 support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only necessary in a handful of non-UTF-8 charsets. Setting the last input flag on the final
decodeisn't sufficient: the decoder state must be flushed in a separate call.Fixes #2664.