Pull - compilation changes...#2196
Merged
mpilquist merged 1 commit intotypelevel:developfrom Dec 29, 2020
Merged
Conversation
- WE remove the use of the `BuildR` subclass of Run, as well as the continuation-like `CallRun` type alias. - We remove the use of `F.attempt` after recursive calls to `go`, since errors are now also processed within the - For the ViewRunner, to avoid a stack overflow in one of the texts, we modify the method `out` to include a manual unrolling loop.
diesalbla
added a commit
to diesalbla/fs2
that referenced
this pull request
May 14, 2021
We fix a memory leak that was introduced in a previous Pull Request typelevel#2196 Note that some of the changes in that PR had already been reverted to fix another memory leak.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildRsubclass of Run, as well as thecontinuation-like
CallRuntype alias.F.attemptafter recursive calls togo,since errors are now also processed within the
we modify the method
outto include a manual unrolling loop.