Make deprecated IO.onError package private#4343
Merged
djspiewak merged 1 commit intotypelevel:series/3.6.xfrom Apr 4, 2025
Merged
Make deprecated IO.onError package private#4343djspiewak merged 1 commit intotypelevel:series/3.6.xfrom
IO.onError package private#4343djspiewak merged 1 commit intotypelevel:series/3.6.xfrom
Conversation
armanbilge
changed the title
IO.onError package private on series/3.6.xIO.onError package private
djspiewak
requested changes
Apr 3, 2025
|
|
||
| import cats.effect.{BaseSpec, IO} | ||
|
|
||
| class IOCompilationSpec extends BaseSpec { |
Member
There was a problem hiding this comment.
Can just put this into IOSpec.
Contributor
Author
There was a problem hiding this comment.
When it's in IOSpec it picks up the deprecated method. Is that ok?
Member
There was a problem hiding this comment.
Ooooh I see, this is outside the package. Okay nvm
djspiewak
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a repeat of #4341 targeting
series/3.6.xinstead. Fine with closing this one or the other one, no worries :)closes #4329
This is a source breaking change for Scala 2.12