Make deprecated IO.onError package private#4341
Closed
CJSmith-0141 wants to merge 1 commit intotypelevel:series/3.xfrom
Closed
Make deprecated IO.onError package private#4341CJSmith-0141 wants to merge 1 commit intotypelevel:series/3.xfrom
IO.onError package private#4341CJSmith-0141 wants to merge 1 commit intotypelevel:series/3.xfrom
Conversation
Contributor
Author
|
Looks like making it package private doesn't work for |
Member
|
I think on 2.12 you can't use a total function in place of a partial function. So that test would have to be only for 2.13+ |
CJSmith-0141
force-pushed
the
series/3.6.x
branch
from
aed8c85 to
220164f
Compare
Contributor
Author
|
Ok since this would be a source breaking change for Scala I also moved the test to be 2.13+. |
Member
|
The previous change was already source breaking because Scala 2.12 can't infer the parameter type of the function passed to an overloaded method like |
Member
|
@armanbilge Are we going to retarget this to 3.6? |
armanbilge
requested changes
Apr 3, 2025
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
Are we going to retarget this to 3.6?
Yes!
Member
|
superseded #4343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a test to make sure that code outside the package can still compile with a total function.
Closes #4329
Thank you @armanbilge for the solve and @Grogs for the writeup.