Document PollingSystem#metrics#4334
Merged
armanbilge merged 2 commits intotypelevel:series/3.6.xfrom Apr 3, 2025
Merged
Conversation
armanbilge
reviewed
Apr 1, 2025
| * @param poller | ||
| * The poller for which metrics are being retrieved. | ||
| * @return | ||
| * An instance of PollerMetrics representing the current metrics of the poller. |
Member
There was a problem hiding this comment.
It's subtle, but I think this description is slightly confusing. This method doesn't return the current metrics of the poller (i.e. PollerMetrics is not an immutable datatype of metrics). Instead, it returns a PollerMetrics instance that can be used to (unsafely, side-effectually) retrieve the current metrics for that poller.
armanbilge
changed the title
PollingSystem#metrics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.