Securely implement UUIDGen for Scala.js#2945
Merged
armanbilge merged 2 commits intotypelevel:series/3.3.xfrom Apr 5, 2022
Merged
Securely implement UUIDGen for Scala.js#2945armanbilge merged 2 commits intotypelevel:series/3.3.xfrom
UUIDGen for Scala.js#2945armanbilge merged 2 commits intotypelevel:series/3.3.xfrom
Conversation
djspiewak
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR relates to CVE-2022-28355 aka GHSA-j2f9-w8wh-9ww4 regarding the insecure implementation of
java.util.UUID.randomUUID()in Scala.js.The fix implemented by Scala.js was to re-implement
java.util.UUID.randomUUID()in terms ofjava.security.SecureRandom, and then make twoSecureRandomartifacts available:Although depending on the fake artifact is strongly discouraged, it's still out there. After discussing with @cquiroz, given the lack of failure mode and non-determinism should both artifacts somehow end up on the classpath, it seems the safest thing to do is avoid using either of these in Cats Effect and instead rely on our own secure implementation.
This is reminiscent of the situation with the two weak reference libs, in which we decided to shade the "true" implementation within CE in #2673 (comment).
This PR does two things:
JavaSecureRandomfrom ImplementRandom#javaSecuritySecureRandomon Scala.js #2906 with the implementation from https://github.com/scala-js/scala-js-java-securerandomUUIDGenon Scala.js by inlining the changes from Fix #4657: Implement UUID.randomUUID() using java.security.SecureRandom. scala-js/scala-js#4659 using our internalJavaSecureRandom