Fix Async#fromCompletableFuture cancelation#2907
Merged
vasilmkd merged 5 commits intotypelevel:series/3.3.xfrom Mar 24, 2022
Merged
Fix Async#fromCompletableFuture cancelation#2907vasilmkd merged 5 commits intotypelevel:series/3.3.xfrom
Async#fromCompletableFuture cancelation#2907vasilmkd merged 5 commits intotypelevel:series/3.3.xfrom
Conversation
armanbilge
changed the title
Async#fromCompletableFuture cancelation
Member
Author
|
Update: I was being dumb and not giving a chance for the fiber to start before canceling. Needed an |
Member
Author
|
Wait, nope, still broken 🤔 |
vasilmkd
approved these changes
Mar 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2903. Supersedes #2904.
The bad news is, my test doesn't pass with @bplommer's fix 🤔 opening in case anyone has some ideas.
/cc @Daenyth for the test