Fix CompletableFuture cancelation#2904
Conversation
|
cc @Daenyth |
|
LGTM, but a test would be really good for this. |
|
We discussed how to write a test on Discord. The tl;dr is create an uncancelable "never" |
|
There was some discussion on Discord about how to test this - I can't promise to do that in the next couple of days, so feel free to fork this PR with a test. Edit: what @armanbilge said |
|
@armanbilge Can you please handle this? Thanks. |
|
Yup I'm working on #2902, I can do this next. |
|
Closing in favor of #2907. |
I think this fixes #2903 but I haven't yet written a regression test.