Added publish settings autoplugin#2860
Conversation
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
I expect to be overridden, but 👎
This PR and #2857 both fix publishing to s01. The difference is that this PR supports git worktrees but no Scala3 or JS MiMa, whereas #2857 supports MiMa for all artifacts, but no git worktrees.
And we literally just picked up Scala 3 issues, with MiMa, while testing local release. Unless I'm missing something, there are certainly ways to use git without worktrees, but no-one is checking MiMa unless you configure it :)
I'd like to see a PR that fixes MiMa along with publishing, no preference at all as to how.
|
I agree with the sentiment, but for the next major relese 3.4.x. 3.3.7 should take precedence in this case. |
|
Well, I said my piece, and to his credit @djspiewak make a good effort to try and work around this. But it's a long thread of issues with sbt-git and upstream friends unraveling as we pull. So let's not block. |
|
To summarize what @armanbilge and I decided:
|
3 participants
Temporary fix until #2857 is ready