Sequential Dispatcher#2854
Merged
djspiewak merged 9 commits intotypelevel:series/3.xfrom Apr 26, 2022
Merged
Conversation
vasilmkd
reviewed
Mar 1, 2022
Member
vasilmkd
left a comment
vasilmkd
left a comment
There was a problem hiding this comment.
Nice and clean. Only the one question.
benchmarks/src/main/scala/cats/effect/benchmarks/DispatcherBenchmark.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
So one immediate problem with doing away with the ADT is it means we can't support |
Member
|
TBH I hadn't considered allowing introspection at all. When I need a dispatcher, I usually create exactly what I need on-the-spot, instead of asking someone else to give it to me? |
djspiewak
commented
Mar 2, 2022
armanbilge
reviewed
Mar 2, 2022
Co-authored-by: Arman Bilge <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a little less of an SPSC
Dispatcherand more MPSC, and definitively a lot more about "short actions that you want to be sequential". Basically this special-cases just a bit for theq.offercase, which is obviously quite common in practice. Haven't added benchmarks back, but anecdotally from test runs this appears to be around a 1-2 order of magnitude improvement in those cases.Closes #2768