Hard exit in Node.js IOApp#2707
Merged
djspiewak merged 1 commit intotypelevel:series/3.3.xfrom Dec 31, 2021
Merged
Conversation
djspiewak
approved these changes
Dec 31, 2021
Member
djspiewak
left a comment
djspiewak
left a comment
There was a problem hiding this comment.
I think this is the right thing to do. At the very least it matches the JVM semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #2630 by enforcing a hard-exit. A graceful exit in Node.js waits for the event loop to become empty, which may not happen if there are leaked fibers.
I still think it would be good to issue a warning about leaked fibers, but this at least solves the confusing problem of the app completely hanging on termination.