Skip to content

Revert Async#fromPromise generalization#2272

Merged
djspiewak merged 3 commits intotypelevel:series/3.xfrom
djspiewak:bug/thenable
Aug 28, 2021
Merged

Revert Async#fromPromise generalization#2272
djspiewak merged 3 commits intotypelevel:series/3.xfrom
djspiewak:bug/thenable

Conversation

@djspiewak
Copy link
Copy Markdown
Member

@djspiewak djspiewak commented Aug 28, 2021

The source compatibility breakage was somewhat extreme.

Fixes #2271

@armanbilge
Copy link
Copy Markdown
Member

Can we at least cherry-pick the original fromThenable into this? 8e0cc4e

@djspiewak
Copy link
Copy Markdown
Member Author

I think that's probably what we will do, but I would rather bias back to a safe state and then move forward with additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FS2 compilation failures due to change in signature of fromPromise

3 participants