feat: utils for measuring effect time#1677
Merged
kubukoz merged 3 commits intotypelevel:series/3.xfrom Feb 13, 2021
patseev:series/3.x
Merged
feat: utils for measuring effect time#1677kubukoz merged 3 commits intotypelevel:series/3.xfrom patseev:series/3.x
kubukoz merged 3 commits intotypelevel:series/3.xfrom
patseev:series/3.x
Conversation
patseev
changed the title
djspiewak
requested changes
Feb 11, 2021
Member
djspiewak
left a comment
djspiewak
left a comment
There was a problem hiding this comment.
This is fantastic. Just the one small change about monotonic vs realTime, and additionally I think it can be moved up to Clock since it doesn't rely on sleep or anything concurrent.
kernel/shared/src/main/scala/cats/effect/kernel/GenTemporal.scala
Outdated
Show resolved
Hide resolved
kubukoz
suggested changes
Feb 11, 2021
kernel/shared/src/main/scala/cats/effect/kernel/syntax/ClockSyntax.scala
Outdated
Show resolved
Hide resolved
kernel/shared/src/main/scala/cats/effect/kernel/syntax/ClockSyntax.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Made all requested changes. |
Member
|
I would like to see that, but I'm not sure we should do that... |
joroKr21
reviewed
Feb 12, 2021
kernel/shared/src/main/scala/cats/effect/kernel/syntax/ClockSyntax.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Georgi Krastev <[email protected]>
kubukoz
approved these changes
Feb 13, 2021
Member
kubukoz
left a comment
kubukoz
left a comment
There was a problem hiding this comment.
I think we got it! @djspiewak I think your concerns were addressed, but feel free to blame me if anything is still missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1672